Revert #383: restore host-AX-publish ceiling to 400ms#384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
60ms was too tight in practice — rolled back to the 400ms ceiling. The fail-open accept tap in #382 remains as the swallow fix.
Greptile Summary
Reverts the
hostPublishWaitCeilingMsconstant from 60ms (introduced in #383) back to 400ms, and replaces the doc comment with an empirical rationale. The #382 fail-open accept-tap fix is unaffected.contenteditablepublish on a busy page is reliably captured before generation fires.Confidence Score: 5/5
Safe to merge — single-constant revert with no logic changes.
The only change is restoring a timeout constant from 60ms to 400ms and refreshing the accompanying doc comment. The polling logic (pollForHostPublish) is untouched; the fail-open accept tap from #382 is untouched. No new code paths are introduced.
No files require special attention.
Important Files Changed
Sequence Diagram
sequenceDiagram participant CGEvent as CGEvent Tap participant SuggC as SuggestionCoordinator participant FocusM as FocusModel (AX) participant Predict as Prediction Pipeline CGEvent->>SuggC: keystroke captured SuggC->>SuggC: schedulePredictionAfterHostPublishDelay() SuggC->>FocusM: refreshNow() (snapshot baseline) loop Poll every 30ms, up to ~370ms (ceiling 400ms) SuggC->>FocusM: refreshNow() alt AX state changed (text / element / selection) SuggC->>Predict: schedulePrediction() else "Ceiling reached (nextElapsed >= 400ms)" SuggC->>Predict: schedulePrediction() [fallback] else Still waiting SuggC->>SuggC: asyncAfter(30ms) → pollForHostPublish end endReviews (1): Last reviewed commit: "Revert "Drop host-AX-publish ceiling to ..." | Re-trigger Greptile