-
Notifications
You must be signed in to change notification settings - Fork 69
Closed
Description
There are still a number of uses of unsafe in the encoder code, more specifically in the match finding code to avoid bounds checks inside tight loops. While we've looked over them before, it would be a good idea to check them again and try to get rid of as many as we can if they have no or negligible effect on performance. In many of the unsafe calls the compiler may already be able to optimize them away anyhow.
The only unsafe code in the decoder are simple bytes to integer conversions, which should be sound.
Once 1.34 is reliably available in distros, we can switch to using the built-in functions for converting from bytes to integers.
Metadata
Metadata
Assignees
Labels
No labels