Skip to content

Elementor Pro Forms Integration#56

Merged
merlinfuchs merged 6 commits intomainfrom
elementor-forms
Sep 26, 2022
Merged

Elementor Pro Forms Integration#56
merlinfuchs merged 6 commits intomainfrom
elementor-forms

Conversation

@merlinfuchs
Copy link
Copy Markdown
Member

@merlinfuchs merlinfuchs commented Sep 24, 2022

  • Add form field for friendly captcha
  • Validate captcha solution on submit
  • Display errors correctly (only a generic error is displayed right now)
  • Check if the most common use-cases are covered
  • Widget preview in editor (doesn't render atm for some reason)

We previously had issues implementing an integration for Elementor because their documentation was insufficient. Specifically the documentation for adding new form fields was missing, this was recently resolved and can be found here: https://developers.elementor.com/docs/form-fields/

closes #28
closes #14

@merlinfuchs merlinfuchs changed the title [WIP ]Elementor Integration [WIP ] Elementor Pro Forms Integration Sep 24, 2022
@merlinfuchs
Copy link
Copy Markdown
Member Author

Check if the most common use-cases are covered

This is how it looks right now: (it renderes a placeholder in the editor)
grafik
Users can add the widget as a form field and there are no additional settings. I could add the option to overwrite the default sitekey and language here:
grafik

The other integrations don't have these options so I wasn't sure if we want it.
@dev-love what do you think? does this already cover the most common use-cases or is there more?

@merlinfuchs merlinfuchs changed the title [WIP ] Elementor Pro Forms Integration [WIP] Elementor Pro Forms Integration Sep 24, 2022
@dev-love
Copy link
Copy Markdown
Contributor

@merlinfuchs I think this should already be the most common use case. Something important would be that the integration is also working if there are two Elementor forms protected by FC on one page, e.g. a newsletter and a contact form. Not sure if this is already working, but apart from that we can get started with this imo :)

@merlinfuchs
Copy link
Copy Markdown
Member Author

As far as I can tell the integration works for multiple forms on one page as well. I think the other integrations add the widget to all forms, with this one the user has to add it to the forms where they want it 👍

@dev-love
Copy link
Copy Markdown
Contributor

@merlinfuchs Sounds great! :) Did you already add a description to the Elementor Pro checkbox in the FC plugin settings with a quick explainer about how to add FC to the forms?

@merlinfuchs
Copy link
Copy Markdown
Member Author

Added a small description and explanation now 👍

@merlinfuchs merlinfuchs changed the title [WIP] Elementor Pro Forms Integration Elementor Pro Forms Integration Sep 26, 2022
Copy link
Copy Markdown
Collaborator

@gzuidhof gzuidhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, really happen to add Elementor Pro Forms to the list of supported form frameworks. Could you add an entry to the changelog?

@merlinfuchs merlinfuchs merged commit c1a39ee into main Sep 26, 2022
@merlinfuchs merlinfuchs deleted the elementor-forms branch September 26, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Elementor Support Elementor

3 participants