Rewrite setcookie using new syntax#8447
Merged
Alkarex merged 2 commits intoFreshRSS:edgefrom Jan 28, 2026
Merged
Conversation
Follow-up of FreshRSS#2630 now that we have PHP 7.3+ (even PHP 8.1+). * The new syntax natively supports `samesite`, and also avoids the need of re-setting all parameters. * Use automatic path instead of own function `getCookieDir()`. Follow-up of FreshRSS#8446 * Sanitize lifetime of session cookies from PHP ini to avoid likely invalid/misunderstood values
Alkarex
commented
Jan 18, 2026
| self::keepCookie($cookie['lifetime']); | ||
| $params = session_get_cookie_params(); | ||
| // Sanitize lifetime of session cookies from PHP ini `session.cookie_lifetime` (default 0) | ||
| $params['lifetime'] = ($params['lifetime'] <= 0 || $params['lifetime'] > 86400) ? 0 : $params['lifetime']; |
Member
Author
There was a problem hiding this comment.
I am wondering whether we should just use 0 here instead of trying to use session.cookie_lifetime from php.ini (default 0).
Member
Author
There was a problem hiding this comment.
Let's come back to that in another PR if desired
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #2630 now that we have PHP 7.3+ (even PHP 8.1+).
samesite, and also avoids the need of re-setting all parameters.getCookieDir().Follow-up of #8446