Conversation
…reshRSS into 4761-sort-order-per-feed
|
Hello and thanks for the PR. Regarding the approach, I think it is quite different from what is asked in #4761 where the idea is that when accessing a given feed individually, the default sorting should be a function of a preference defined for that feed. Likewise at category level (which can be done in another PR). And indeed, I do not think it make much sense in the same view to mix various sorting orders.
I realise that it will make this PR quite different from your first version, and sorry for that, but I do believe it would address a more common use-case and be easier to integrate to the rest as well as maintain over time. I hope it can make sense to you as well. I will make a few more minor reviews inline. |
Alkarex
left a comment
There was a problem hiding this comment.
The secondary sorting criterion is defined but not used, so this must be addressed.
The logic is a bit complicated though, so it could be an approach to leave it to a follow-up PR.
|
@PeterVavercak Tests welcome if you are around, in particular regarding paging (i.e. autoload of more articles) |

Adresses #4761
Changes proposed in this pull request:
How to test the feature manually:
Pull request checklist:
Additional information can be found in the documentation.