Merged
Conversation
Alkarex
reviewed
Sep 15, 2025
app/FreshRSS.php
Outdated
| * - Enable user extensions (need all the other initializations) | ||
| */ | ||
| public function init(): void { | ||
| define('FRESHRSS_INIT', true); |
Member
There was a problem hiding this comment.
Instead of this additional constant, would it be sufficient to test whether the session has already been started?
Member
Author
There was a problem hiding this comment.
Hm I thought Minz_Session::init was being called twice in some place, but I missed the isset check, because of that I didn't do that.
So yes, but I would have to test what the behavior is when the session isn't setup correctly.
probably is fine though since there is no session_start() before
The ideal solution would be to wrap everything inside install.php into a function and call the function after including install.php somewhere.
Or refactor install.php into a controller
Alkarex
reviewed
Sep 15, 2025
Member
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent
install.phpfrom being accessed in unintended places