Fix JS error when navigating to last article with keyboard#7957
Merged
Alkarex merged 1 commit intoFreshRSS:edgefrom Sep 12, 2025
Merged
Fix JS error when navigating to last article with keyboard#7957Alkarex merged 1 commit intoFreshRSS:edgefrom
Alkarex merged 1 commit intoFreshRSS:edgefrom
Conversation
Member
|
I'd think the expected behavior is the next category when applicable and otherwise nothing. (Which I think is broadly what already happens?) |
Member
Author
Does not due to the error as far as I can tell |
Member
|
I meant in all other scenarios, hence why it should conform. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This error would print in the console if navigating to last article with J or K key:
To reproduce the bug:
first_feed()orlast_feed()note: I'm not sure if the fix is what the expected behavior is supposed to be