Skip to content

Change how files are included#7916

Merged
Alkarex merged 1 commit intoFreshRSS:edgefrom
aledeg:refactor/paths
Sep 5, 2025
Merged

Change how files are included#7916
Alkarex merged 1 commit intoFreshRSS:edgefrom
aledeg:refactor/paths

Conversation

@aledeg
Copy link
Member

@aledeg aledeg commented Sep 5, 2025

  1. include, include_once, require and require_once are expressions not functions, parentheses are not necessary.
  2. to move up the directory tree, it's better to use the dirname function instead of relying on /...

Changes proposed in this pull request:

  • See above

How to test the feature manually:

  1. nothing has changed, everything is working as before

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

Additional information can be found in the documentation.

1. `include`, `include_once`, `require` and `require_once` are expressions not functions, parentheses are not necessary.
2. to move up the directory tree, it's better to use the `dirname` function instead of relying on `/..`.
@Alkarex Alkarex added this to the 1.27.1 milestone Sep 5, 2025
@Alkarex Alkarex added the php Pull requests that update Php code label Sep 5, 2025
@Alkarex Alkarex merged commit 23ba48c into FreshRSS:edge Sep 5, 2025
1 check passed
@aledeg aledeg deleted the refactor/paths branch September 5, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants