Skip to content

Fixes for no-cache.txt#7907

Merged
Alkarex merged 4 commits intoFreshRSS:edgefrom
Inverle:fix-no-cache
Sep 5, 2025
Merged

Fixes for no-cache.txt#7907
Alkarex merged 4 commits intoFreshRSS:edgefrom
Inverle:fix-no-cache

Conversation

@Inverle
Copy link
Member

@Inverle Inverle commented Sep 3, 2025

@Alkarex
Copy link
Member

Alkarex commented Sep 3, 2025

Isn't the fix to simply include require(LIB_PATH . '/http-conditional.php'); unconditionally?

@Inverle
Copy link
Member Author

Inverle commented Sep 3, 2025

Isn't the fix to simply include require(LIB_PATH . '/http-conditional.php'); unconditionally?

I think we don't want to call httpConditional() if no-cache.txt exists
I didn't want to put file_exists in each condition, but I can do that instead if we have to avoid making changes to http-conditional
(since that can also be forgotten later for such a niche feature)

@Alkarex
Copy link
Member

Alkarex commented Sep 3, 2025

Yes please 👍🏻

@Inverle
Copy link
Member Author

Inverle commented Sep 3, 2025

@Alkarex done

@Alkarex Alkarex linked an issue Sep 5, 2025 that may be closed by this pull request
@Alkarex Alkarex merged commit 858616f into FreshRSS:edge Sep 5, 2025
1 check passed
@Inverle Inverle deleted the fix-no-cache branch September 5, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] no-cache.txt causes undefined function errors

2 participants