Skip to content

refactor value setting for javascript variables#7906

Merged
Alkarex merged 1 commit intoFreshRSS:edgefrom
aledeg:refactor/javascript-vars
Sep 3, 2025
Merged

refactor value setting for javascript variables#7906
Alkarex merged 1 commit intoFreshRSS:edgefrom
aledeg:refactor/javascript-vars

Conversation

@aledeg
Copy link
Member

@aledeg aledeg commented Sep 3, 2025

When retrieving an unset shortcut value, the error is not silenced but instead we use the null-coalesce operator to define a default value.

See #7290

Closes #7290

Changes proposed in this pull request:

  • default values are set instead of silencing errors.

How to test the feature manually:

  1. Validate that empty shortcuts are configured properly in the interface.
  2. Validate that defined shortcuts are configured properly in the interface.

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

Additional information can be found in the documentation.

@aledeg aledeg added the System care Everything related to system care label Sep 3, 2025
@aledeg aledeg force-pushed the refactor/javascript-vars branch from c5693ff to e801d62 Compare September 3, 2025 04:35
When retrieving an unset shortcut value, the error is not silenced but
instead we use the null-coalesce operator to define a default value.

See FreshRSS#7290
@Alkarex Alkarex added this to the 1.27.1 milestone Sep 3, 2025
@Alkarex Alkarex merged commit 94c53ae into FreshRSS:edge Sep 3, 2025
1 check passed
@aledeg aledeg deleted the refactor/javascript-vars branch September 3, 2025 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

System care Everything related to system care

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor javascript_vars.phtml

2 participants