Merged
Conversation
Alkarex
reviewed
Aug 31, 2025
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Member
Author
|
Before merging it would be useful to check if there are any other characters that may be used as line delimiter other than FreshRSS/app/Models/LogDAO.php Line 18 in 87879e8 edit: looks like not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can inject new lines into
Minz_Request::paramString('challenge')f.e. by logging in with challengex%0D%0A[Sat, 30 Aug 2025 21:39:50 +0000] [warning] --- somethingFreshRSS/app/Controllers/authController.php
Line 181 in 200eafb
If it were
Minz_Request::paramString('challenge', plaintext: true)or somewhere else, HTML could be injected intolevelFreshRSS/app/views/index/logs.phtml
Line 27 in 200eafb
which is why its values are restricted now