Skip to content

Improve leave validation#7830

Merged
Alkarex merged 2 commits intoFreshRSS:edgefrom
Inverle:improve-leave-validation
Aug 31, 2025
Merged

Improve leave validation#7830
Alkarex merged 2 commits intoFreshRSS:edgefrom
Inverle:improve-leave-validation

Conversation

@Inverle
Copy link
Member

@Inverle Inverle commented Aug 16, 2025

fix: no confirmation popup was shown when exiting slider with shortcut (ESC)
fix: no confirmation popup was shown after exiting slider and having reset the icon to default or set by extension
fix: input for close_dropdown wasn't named correctly for label to work
refactor: close_dropdown was renamed to close_menus

TODO for later PR: move custom favicon code to feed.js instead of extra.js

@Alkarex Alkarex added this to the 1.28.0 milestone Aug 16, 2025
@Alkarex Alkarex added the UI 🎨 User Interfaces label Aug 16, 2025
@Alkarex
Copy link
Member

Alkarex commented Aug 18, 2025

Can it wait till after the release of 1.27.0?

@Inverle
Copy link
Member Author

Inverle commented Aug 18, 2025

Probably

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
@Alkarex Alkarex merged commit 87879e8 into FreshRSS:edge Aug 31, 2025
1 check passed
@Inverle Inverle deleted the improve-leave-validation branch August 31, 2025 17:45
@Inverle Inverle restored the improve-leave-validation branch September 2, 2025 05:11
@Inverle Inverle deleted the improve-leave-validation branch September 2, 2025 05:11
@Alkarex Alkarex modified the milestones: 1.28.0, 1.27.1 Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI 🎨 User Interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants