Regenerate session ID on login#7829
Merged
Alkarex merged 6 commits intoFreshRSS:edgefrom Aug 30, 2025
Merged
Conversation
Member
Author
|
works properly now |
Alkarex
reviewed
Aug 16, 2025
lib/Minz/Session.php
Outdated
| return; | ||
| } | ||
| $lifetime = session_get_cookie_params()['lifetime']; | ||
| setcookie('FreshRSS', $newId, $lifetime, self::getCookieDir(), '', Minz_Request::isHttps(), true); |
Member
There was a problem hiding this comment.
Please pass 'FreshRSS' as parameter $name to keep the same convention as the related functions just below
Member
|
Can it wait till after the release of 1.27.0? |
Member
Author
|
Probably |
Member
Author
|
Forgot to also apply this when creating user or deleting account Not critical but will make a PR later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7762