Sometimes it's buggy when the icon can't be loaded, but that should usually follow with an error like this:

@Inverle I have fixed the support of multiple icons, in particular the bottom one that was broken (when opening an article and using the star icon at the bottom). Please test a bit more
e549dfd

Sometimes it's buggy when the icon can't be loaded

This is due to me testing on nginx (probably caching issue), this doesn't happen inside the FreshRSS apache2 container.
It also doesn't need <link rel="preload"> to function properly.

@Inverle I have fixed the support of multiple icons, in particular the bottom one that was broken (when opening an article and using the star icon at the bottom). Please test a bit more e549dfd

I didn't realize there was a bookmark icon at the bottom too

By the way, the same should be done for read/unread

Edit: Done

Read and unread icons have their javascript var in javascript_vars.phtml but bookmark icon doesn't, despite the fact that different themes may have different starred.svg/non-starred.svg icons, just as is the case with read.svg/unread.svg

Read and unread icons have their javascript var in javascript_vars.phtml but bookmark icon doesn't, despite the fact that different themes may have different starred.svg/non-starred.svg icons, just as is the case with read.svg/unread.svg

Let's keep this improvement for another PR. Help welcome

Cheers.

One thing I failed to realize when taking a peek a few days ago is that we already have a different spinner in certain circumstances, for example loading more articles and updating FreshRSS. Should it be replaced by this one or vice versa?

Cheers.

One thing I failed to realize when taking a peek a few days ago is that we already have a different spinner in certain circumstances, for example loading more articles and updating FreshRSS. Should it be replaced by this one or vice versa?

loader.gif doesn't really work well

https://github.com/FreshRSS/FreshRSS/blob/edge/p/themes/base-theme/loader.gif

Should it be replaced by this one

Indeed, probably a good idea

I find this moving icon very distracting. Especially as my server is not very fast and it runs a bit of time.

Maybe there should be an option to disable this

Especially as my server is not very fast and it runs a bit of time.

That's one of the use cases for it

Maybe there should be an option to disable this

I second this.
Or is there a CSS or JS rule I could use to prevent it for spinning/displaying?

Maybe there should be an option to disable this

Or just a static icon along the lines of https://icons.getbootstrap.com/icons/arrow-clockwise/ for example?

In the <img alt , I am using ⌛

@Alwaysin

try putting this in your UserJS:

"use strict";

window.addEventListener("load", () => {
  document.querySelectorAll(".bookmark, .read").forEach(el => el.addEventListener("click", () => {
    window.oldIconSrc = el.querySelector('img').getAttribute('src');
  }));

  new MutationObserver((mutationsList) => {
    for (let mutation of mutationsList) {
      if (mutation.type === "attributes" && mutation.attributeName === "src") {
        if (mutation.target.src.includes('themes/icons/spinner.svg')) {
          mutation.target.src = window.oldIconSrc;
          mutation.target.classList.remove('spinner');
        }
      }
    }
  }).observe(stream, {
    attributes: true,
    subtree: true
  });
});

this should restore the original behavior
edit: may be slightly buggy, but you won't see a spinning icon anymore

Thank you. I have this instead of the spinning icon:

At least it does not move now ^_^

At least it does not move now ^_^

I edited the previous code, it should work better but it's not guaranteed

A static icon doesn't look bad either, as @Frenzie suggested, so for now you could replace p/themes/icons/spinner.svg with https://icons.getbootstrap.com/icons/arrow-clockwise/

https://framagit.org/nicofrand/xextension-threepanesview/-/issues/28

This looks OK when the spinner appears as a reaction to an explicit action (i.e. clicking on read/unread/star icon).

But this is too distracting when you're just browsing through the feed (e.g. via next hotkey). I ended up making this hack:

diff --git a/p/scripts/main.js b/p/scripts/main.js
index c0e31ef9..fdfa9b6d 100644
--- a/p/scripts/main.js
+++ b/p/scripts/main.js
@@ -319,11 +319,13 @@ function mark_read(div, only_not_read, asBatch) {
        }
        pending_entries[div.id] = true;

-       div.querySelectorAll('a.read > .icon').forEach(icon => {
-               icon.src = context.icons.spinner;
-               icon.alt = '⏳';
-               icon.classList.add('spinner');
-       });
+       if (!asBatch) {
+               div.querySelectorAll('a.read > .icon').forEach(icon => {
+                       icon.src = context.icons.spinner;
+                       icon.alt = '⏳';
+                       icon.classList.add('spinner');
+               });
+       }

        const asRead = div.classList.contains('not_read');
        const entryId = div.id.replace(/^flux_/, '');

fully agree with @WGH- , way too distracting when reading through, should only be visible for explicit actions

PR welcome to make an option

Like I said before, I think a static (or in any case less active) icon would obviate the need for an option?

Like I said before, I think a static (or in any case less active) icon would obviate the need for an option?

Ok, fair enough. PR welcome