Conversation
To avoid potential CSRF risks
|
In this PR, the logout is now a POST instead of GET to address a security issue, but I have only tested with Web form and not OpenID Connect. @aaronschif if you are around, help welcome to test with ODIC the logout function you did in #5351 Ping a few others for test, as you may have different setups: @Hani-K, @UncleArya, @jasonajack, @mpalatsi, @ShaddyDC, @pando85 ... Thanks P.S. To test this branch, if using Docker, you can modify your Docker Compose like so: freshrss:
image: freshrss/freshrss:7489
build:
context: https://github.com/Alkarex/FreshRSS.git#post-logout
dockerfile: Docker/Dockerfile
... |
Just tested with the branch you mentioned. Logout worked as expected with my OIDC setup, no issues to report. Hope that helps. |
Thanks for the test @UncleArya . Do you know whether your logout endpoint has any protection against XSRF, for instance through a secret? This would be to avoid for instance an image coming from a feed, which address is the same than your OIDC logout |
|
|
|
@UncleArya What happens when you click logout in your case? Are you immediately logged out, or do you have one more action to do? |
try adding: button {
font-family: OpenSans, Cantarell, Helvetica, Arial, sans-serif;
}the hover animation isn't present anymore either so this is needed too: button:hover .icon {
filter: brightness(1.5);
transition: 0.1s linear;
}(changing |
|
Don't forget about :focus with buttons. You generally want to get that in there the same as :hover. |
|
Edits to the PR welcome 😉 |
fix of #7489 (comment) Regression #7314
So you can see keyboard focus. In reply to <FreshRSS#7489 (comment)>.
In the menu on the left-hand side, not the one on the right-hand side |
So you can see keyboard focus. In reply to <#7489 (comment)>.
|
@Inverle Could you please try again making sure to clear the browser cache? I cannot seem to reproduce the issue |
|
Yes, it's still happening. |
Add missing rules. fix FreshRSS#7489 (comment)
* Themes fix CSS .as-link Add missing rules. fix #7489 (comment) * More fixes




To avoid potential CSRF risks