Conversation
|
Could you summarize the changes a bit? It looks like nearly everything was changed. Also pinging a few previous contributors @ramazansancar @CilgaIscan |
There are some spelling mistakes in certain places, as well as changes in the use of uppercase and lowercase letters. Apart from that, general changes have been made to make the sentences more meaningful. |
|
@mikropsoft So why were the |
You might be right, I fixed it. Since no changes will be made to these texts anyway, I thought it was unnecessary. Anyway. |
|
Everything looks good except what I wrote. Good job. @mikropsoft FYI @Frenzie |
Ignore is necessary to signal that they aren't the same because they haven't been translated yet. Similarly the todos should be removed if they're no longer todo. |
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
|
@Frenzie done i think. |
|
The newlines at the end of file were removed. Please add those back. :-) There are still some todos that should be marked as dirty instead (or not as todo at all). See https://github.com/FreshRSS/FreshRSS/actions/runs/13947871375/job/39054469605?pr=7442 for details. |
|
@mikropsoft There are still some |
So, do you want me to remove all the |
It would be nice if the translations were removed. |
|
Also the tab please. But maybe there's a command to do that automatically @Alkarex ? |
I think I understand now. I added a space to the last lines, and as far as I understand, there shouldn't be an issue now, right? Dude, it's really weird that this translation file is in PHP. This is my first time encountering something like this! |
Since the project works with PHP, it is quite normal to have PHP in the language files. |
In the different programming languages I have seen, JSON was mostly used (except for XML). Anyway, it gave an error again, but I couldn't understand this one. |
|
You removed the comments, but not the tabs that were just before the comments. |
Eh, I really didn't understand this sorry 😑. By the way, the editing permission needs to be open, you can make edits on the pr. |
Yes: make fix-all
make test-all |
|
Please add a line for you in https://github.com/FreshRSS/FreshRSS/blob/edge/CREDITS.md |
No description provided.