Skip to content

Improve Turkish Language#7442

Merged
Alkarex merged 13 commits intoFreshRSS:edgefrom
mikropsoft:edge
Apr 1, 2025
Merged

Improve Turkish Language#7442
Alkarex merged 13 commits intoFreshRSS:edgefrom
mikropsoft:edge

Conversation

@mikropsoft
Copy link
Contributor

No description provided.

@Frenzie
Copy link
Member

Frenzie commented Mar 19, 2025

Could you summarize the changes a bit? It looks like nearly everything was changed.

Also pinging a few previous contributors @ramazansancar @CilgaIscan

@mikropsoft
Copy link
Contributor Author

Could you summarize the changes a bit? It looks like nearly everything was changed.

Also pinging a few previous contributors @ramazansancar @CilgaIscan

There are some spelling mistakes in certain places, as well as changes in the use of uppercase and lowercase letters. Apart from that, general changes have been made to make the sentences more meaningful.

@ramazansancar
Copy link
Contributor

@mikropsoft So why were the // IGNORE tags removed? A tag added to make things easier for subsequent translators.

@mikropsoft
Copy link
Contributor Author

@mikropsoft So why were the // IGNORE tags removed? A tag added to make things easier for subsequent translators.

You might be right, I fixed it. Since no changes will be made to these texts anyway, I thought it was unnecessary. Anyway.

@ramazansancar
Copy link
Contributor

Everything looks good except what I wrote. Good job. @mikropsoft

FYI @Frenzie

@Frenzie
Copy link
Member

Frenzie commented Mar 19, 2025

You might be right, I fixed it. Since no changes will be made to these texts anyway, I thought it was unnecessary.

Ignore is necessary to signal that they aren't the same because they haven't been translated yet.

Similarly the todos should be removed if they're no longer todo.

@mikropsoft
Copy link
Contributor Author

@Frenzie done i think.

@Frenzie
Copy link
Member

Frenzie commented Mar 19, 2025

The newlines at the end of file were removed. Please add those back. :-) There are still some todos that should be marked as dirty instead (or not as todo at all). See https://github.com/FreshRSS/FreshRSS/actions/runs/13947871375/job/39054469605?pr=7442 for details.

@ramazansancar
Copy link
Contributor

@mikropsoft There are still some // TODO tags that have not been removed. There are additional areas of change that I have mentioned.

@mikropsoft
Copy link
Contributor Author

@mikropsoft There are still some // TODO tags that have not been removed. There are additional areas of change that I have mentioned.

So, do you want me to remove all the // TODO comments from the files?

@ramazansancar
Copy link
Contributor

@mikropsoft There are still some // TODO tags that have not been removed. There are additional areas of change that I have mentioned.

So, do you want me to remove all the // TODO comments from the files?

It would be nice if the translations were removed.

@Frenzie
Copy link
Member

Frenzie commented Mar 19, 2025

Also the tab please. But maybe there's a command to do that automatically @Alkarex ?
https://github.com/FreshRSS/FreshRSS/actions/runs/13952658293/job/39056553349?pr=7442

@mikropsoft
Copy link
Contributor Author

Also the tab please. But maybe there's a command to do that automatically @Alkarex ? https://github.com/FreshRSS/FreshRSS/actions/runs/13952658293/job/39056553349?pr=7442

I think I understand now. I added a space to the last lines, and as far as I understand, there shouldn't be an issue now, right?

Dude, it's really weird that this translation file is in PHP. This is my first time encountering something like this!

@ramazansancar
Copy link
Contributor

Also the tab please. But maybe there's a command to do that automatically @Alkarex ? https://github.com/FreshRSS/FreshRSS/actions/runs/13952658293/job/39056553349?pr=7442

I think I understand now. I added a space to the last lines, and as far as I understand, there shouldn't be an issue now, right?

Dude, it's really weird that this translation file is in PHP. This is my first time encountering something like this!

Since the project works with PHP, it is quite normal to have PHP in the language files.

@mikropsoft
Copy link
Contributor Author

Since the project works with PHP, it is quite normal to have PHP in the language files.

In the different programming languages I have seen, JSON was mostly used (except for XML). Anyway, it gave an error again, but I couldn't understand this one.

@Frenzie
Copy link
Member

Frenzie commented Mar 19, 2025

You removed the comments, but not the tabs that were just before the comments.

@mikropsoft
Copy link
Contributor Author

You removed the comments, but not the tabs that were just before the comments.

Eh, I really didn't understand this sorry 😑. By the way, the editing permission needs to be open, you can make edits on the pr.

@Alkarex
Copy link
Member

Alkarex commented Mar 19, 2025

But maybe there's a command to do that automatically

Yes:

make fix-all
make test-all

@Alkarex Alkarex added this to the 1.27.0 milestone Mar 19, 2025
@Alkarex Alkarex added the I18n 🌍 Translations label Mar 19, 2025
@Alkarex Alkarex merged commit 4c6bd24 into FreshRSS:edge Apr 1, 2025
1 check passed
@Alkarex
Copy link
Member

Alkarex commented Apr 1, 2025

Please add a line for you in https://github.com/FreshRSS/FreshRSS/blob/edge/CREDITS.md

@Alkarex Alkarex modified the milestones: 1.27.0, 1.26.2 Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I18n 🌍 Translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants