Skip to content

Clarify MINZ usage#7426

Merged
Alkarex merged 5 commits intoFreshRSS:edgefrom
glyn:7425-clarify-MINZ
Mar 24, 2025
Merged

Clarify MINZ usage#7426
Alkarex merged 5 commits intoFreshRSS:edgefrom
glyn:7425-clarify-MINZ

Conversation

@glyn
Copy link
Contributor

@glyn glyn commented Mar 14, 2025

MINZ (archived, read-only) is not a dependency of FreshRSS, which would be very concerning.

Instead, FreshRSS copied MINZ and has evolved it since then under the same license.

Ref: #7425

Move credits

This PR moves the credits from the web UI to the README.

@Alkarex Alkarex added this to the 1.27.0 milestone Mar 14, 2025
@Frenzie
Copy link
Member

Frenzie commented Mar 14, 2025

The others should be marked as TODO. The CLI tool can be used to automate that.

@Alkarex
Copy link
Member

Alkarex commented Mar 14, 2025

Thanks 👍🏻

@marienfressinaud A lot of it seems to be quite obsolete. Furthermore, there are other, more important packages we use and that are not in the list. See https://github.com/FreshRSS/FreshRSS/blob/edge/README.md#included-libraries

Maybe we should remove this string and move the remaining relevant things to the readme.

Copy link
Member

@marienfressinaud marienfressinaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes totally sense 👍

@Alkarex
Copy link
Member

Alkarex commented Mar 17, 2025

Some design elements come from Bootstrap although FreshRSS doesn’t use this framework.

@marienfressinaud I do not think this is relevant anymore, is it?

Icons come from the GNOME project.

@marienfressinaud I am not sure how much of that is left. Would you know?

Open Sans font police has been created by Steve Matteson.

This font is still used, but we have a couple more used by our different themes.

@Frenzie
Copy link
Member

Frenzie commented Mar 17, 2025

Some design elements come from Bootstrap although FreshRSS doesn’t use this framework.

I've always read it as that the general concept of class="form-group" etc. is strongly inspired by Bootstrap but otherwise has nothing to do with Bootstrap at all.

@glyn
Copy link
Contributor Author

glyn commented Mar 17, 2025

Thanks for the feedback. I've pushed some changes to move the credits to the README and delete them from the web UI.

@glyn glyn marked this pull request as ready for review March 17, 2025 14:57
glyn added 3 commits March 17, 2025 14:58
MINZ (archived, read-only) is not a dependency
of FreshRSS, which would be very concerning.

Instead, FreshRSS copied MINZ and has evolved
it since then under the same license.

Ref: FreshRSS#7425
@glyn glyn force-pushed the 7425-clarify-MINZ branch from 92051bb to 84e4ec5 Compare March 17, 2025 14:58
@glyn glyn requested a review from marienfressinaud March 17, 2025 14:58
@marienfressinaud
Copy link
Member

Some design elements come from Bootstrap although FreshRSS doesn’t use this framework.

I've always read it as that the general concept of class="form-group" etc. is strongly inspired by Bootstrap but otherwise has nothing to do with Bootstrap at all.

The look and colors were also very inspired by Bootstrap 2. You can compare the buttons at https://getbootstrap.com/2.3.2/base-css.html#buttons for example. I wrote the CSS myself though, so I'm not sure it's pertinent to keep the reference to Bootstrap (especially as it changed a lot since then).

Icons come from the GNOME project.

I don't think the icons have changed much, so I'd say they all still come from GNOME (for instance, the "read view" icon)

Open Sans font police has been created by Steve Matteson.

This font is still used, but we have a couple more used by our different themes.

I found Lato, Open Sans and Spectral under https://github.com/FreshRSS/FreshRSS/tree/edge/p/themes/fonts

@glyn I noticed that you re-introduced the credit to Minz in the README, you can remove it :)

@Alkarex
Copy link
Member

Alkarex commented Mar 22, 2025

A few more changes applied

@glyn
Copy link
Contributor Author

glyn commented Mar 24, 2025

With @Alkarex's changes, I believe this PR is ready to merge. Please advise. /cc @marienfressinaud, @Frenzie

@Alkarex Alkarex merged commit b0a3ae1 into FreshRSS:edge Mar 24, 2025
1 check passed
@Alkarex
Copy link
Member

Alkarex commented Mar 24, 2025

Let's go for that for now, and do more changes in another PR if needed.

@Alkarex
Copy link
Member

Alkarex commented Mar 24, 2025

@glyn Please add a line for you in https://github.com/FreshRSS/FreshRSS/blob/edge/CREDITS.md

@glyn
Copy link
Contributor Author

glyn commented Mar 24, 2025

@glyn Please add a line for you in https://github.com/FreshRSS/FreshRSS/blob/edge/CREDITS.md

Done! Thanks @Alkarex.

@Alkarex Alkarex modified the milestones: 1.27.0, 1.26.2 Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants