Support multiple JSON fragments in HTML+XPath+JSON mode#7369
Merged
Alkarex merged 3 commits intoFreshRSS:edgefrom Mar 24, 2025
Merged
Support multiple JSON fragments in HTML+XPath+JSON mode#7369Alkarex merged 3 commits intoFreshRSS:edgefrom
Alkarex merged 3 commits intoFreshRSS:edgefrom
Conversation
fix FreshRSS#7352 (reply in thread) E.g. HTML with one `<script type="application/ld+json">...</script>` per item.
Member
Author
<?xml version="1.0" encoding="UTF-8"?>
<opml xmlns:frss="https://freshrss.org/opml" version="2.0">
<head>
<title>FreshRSS</title>
<dateCreated>Mon, 24 Feb 2025 22:33:10 +0100</dateCreated>
</head>
<body>
<outline
text="the-rady-shell-at-jacobs-park-events"
type="HTML+XPath+JSON+DotNotation"
xmlUrl="https://san-diego.events/venue/the-rady-shell-at-jacobs-park-events/"
htmlUrl="https://san-diego.events/venue/the-rady-shell-at-jacobs-park-events/"
description="RSS feed of san-diego.events/venue/the-rady-shell-at-jacobs-park-events/"
frss:jsonItem="$"
frss:jsonItemTitle="name"
frss:jsonItemContent="description"
frss:jsonItemUri="offers[0].url"
frss:jsonItemAuthor="performer.name"
frss:jsonItemTimestamp="startDate"
frss:jsonItemThumbnail="image"
frss:xPathToJson="//body//script[@type="application/ld+json"]"
/>
</body>
</opml>
|
Member
Author
|
Ping @dahlbergc |
Member
|
What an odd page. 🤨 |
Frenzie
approved these changes
Feb 25, 2025
app/Models/Feed.php
Outdated
| $xpath = new DOMXPath($doc); | ||
| $json = @$xpath->evaluate('normalize-space(' . $xPathToJson . ')'); | ||
| return is_string($json) ? $json : null; | ||
| $jsons = @$xpath->evaluate($xPathToJson); |
Member
There was a problem hiding this comment.
Something like JSON fragments might potentially sound better?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #7352 (reply in thread)
E.g. HTML with one
<script type="application/ld+json">...</script>per item.Example: https://san-diego.events/venue/the-rady-shell-at-jacobs-park-events/