Skip to content

Themes: Reference Open Sans font as "Open Sans"#7208

Closed
AesaraB wants to merge 1 commit intoFreshRSS:edgefrom
AesaraB:edge
Closed

Themes: Reference Open Sans font as "Open Sans"#7208
AesaraB wants to merge 1 commit intoFreshRSS:edgefrom
AesaraB:edge

Conversation

@AesaraB
Copy link

@AesaraB AesaraB commented Jan 10, 2025

Closes #7121

Changes proposed in this pull request:

  • Replace font-family: "OpenSans", "Cantarell", "Helvetica", "Arial", sans-serif; string with font-family: "Open Sans", "OpenSans", "Cantarell", "Helvetica", "Arial", sans-serif;

How to test the feature manually:

  1. Open FreshRSS in both Firefox and Chrome
  2. Observe if font-style is rendered in italics
  3. If 2. is not the case, this PR works.

Pull request checklist:

  • clear commit messages
  • code manually tested (by modifying CSS on Firefox developer tools)
  • unit tests written (optional if too hard)
  • documentation updated

Additional information can be found in the documentation.

@AesaraB
Themes: Reference Open Sans font as "Open Sans"
84145e2 
Referencing Open Sans as "OpenSans" in the font-family property makes
everything italic in Firefox, for some reason...
#7129

Signed-off-by: Aesara Binder <aesara@mailbox.org>
@math-GH math-GH mentioned this pull request Jan 11, 2025
Closed
@math-GH
Copy link
Contributor

math-GH commented Jan 11, 2025

should close #7213 too

@Alkarex
Copy link
Member

Alkarex commented Jan 12, 2025 •
edited
Loading

At a quick glance, I do not think this fix is correct.
We provide the font as a Web font, and it should not pick the OS-local version
https://github.com/FreshRSS/FreshRSS/tree/edge/p/themes/fonts
Debugging welcome

FreshRSS/p/themes/base-theme/frss.css

Lines 47 to 54 in a8ef1c3

@font-face {
font-family: 'OpenSans';
font-style: normal;
font-weight: 400;
src: local('Open Sans'), local('OpenSans'),
url('../fonts/OpenSans.woff2') format('woff2'),
url('../fonts/OpenSans.woff') format('woff');
}

Edit: The problem may lie with the local('Open Sans') part

@Alkarex Alkarex mentioned this pull request Jan 12, 2025
Merged
@Alkarex
Copy link
Member

Alkarex commented Jan 12, 2025

Could you please try #7215 instead (not tested)

@AesaraB AesaraB closed this Jan 12, 2025
@AesaraB
Copy link
Author

AesaraB commented Jan 12, 2025

I'll get a container built tomorrow and give it a shot

@Alkarex Alkarex added this to the 1.26.0 milestone Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Theme 🖌

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

[Bug] Everything is italics on Firefox

3 participants

@AesaraB @math-GH @Alkarex