Skip to content

Fix: 6262: Scroll bar if default font-size is smaller than 16px#7168

Merged
Alkarex merged 3 commits intoFreshRSS:edgefrom
math-GH:fix/6262-scrollbar-15px-font-size
Mar 22, 2025
Merged

Fix: 6262: Scroll bar if default font-size is smaller than 16px#7168
Alkarex merged 3 commits intoFreshRSS:edgefrom
math-GH:fix/6262-scrollbar-15px-font-size

Conversation

@math-GH
Copy link
Contributor

@math-GH math-GH commented Jan 1, 2025

Closes #6262

Changes proposed in this pull request:

  • CSS: the search button was too big/not flexible enough for the height because of the padding

How to test the feature manually:

  1. browser configuration: change the default font size from (16pt mostly) to 15 or 14
  2. go to subscription management -> Subscription tools
  3. there should be no scroll bar (because the left hand side navigation is short and the content right hand side is short too)

Side effect: All buttons will be a bit smaller as before (because px -> rem) It should not be an issue at all

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added the UI 🎨 User Interfaces label Jan 1, 2025
@math-GH math-GH added this to the 1.26.0 milestone Jan 1, 2025
@math-GH math-GH changed the title Themes: .btn padding + small adjustments Fix: 6262: Scroll bar if default font-size is smaller than 16px Jan 1, 2025
@nicofrand
Copy link
Contributor

nicofrand commented Jan 10, 2025

Hi!

I just tested with Origin compact like this:

git fetch origin pull/7168/head:testbugfix
git checkout testbugfix

But I could not see any improvement.

@Frenzie
Copy link
Member

Frenzie commented Jan 10, 2025

Did you Ctrl+F5?

@nicofrand
Copy link
Contributor

I emptied my browser cache yes. I also tried emptying data/cache.

@math-GH
Copy link
Contributor Author

math-GH commented Jan 10, 2025

I cannot reproduce it with Origin compact on Firefox and Chromium.

@nicofrand : Do you have set a website zoom or a zoom of your display (via your operating system?)

Could you please support with screenshots (especially an inspect of the header (<header class="header">)?

@nicofrand
Copy link
Contributor

No zoom (in the website or OS or browser). Even with a 16px font-size I have a scrollbar.

image

image

@math-GH
Copy link
Contributor Author

math-GH commented Jan 13, 2025

@nicofrand Could you please give a screenshot of the "layout" tab on the right hand side? It shows the calculated height.

Could you please check the "Nord" theme and "Origine" (not the compact one) theme too?

@nicofrand
Copy link
Contributor

image

No issue with "Nord" nor "Origine" (not compact) themes.

@math-GH
Copy link
Contributor Author

math-GH commented Jan 21, 2025

I cannot reproduce it.
Could you please check that you are on this PR branch with the latest commit? @nicofrand

@nicofrand
Copy link
Contributor

I am:

❯ git log -1 | cat
commit be6076857357189ddf235d175df28ad310c74578
Author: math-gh <1645099+math-GH@users.noreply.github.com>
Date:   Wed Jan 1 23:41:33 2025 +0100

    Themes: .btn padding + small adjustments

@math-GH
Copy link
Contributor Author

math-GH commented Feb 1, 2025

Current situation (as far as I oversee it):
Only Origin compact theme would have an issue. This PR fixes the issues in the other themes.

I would suggest to merge this PR. Maybe I will find the reason later why Origin compact has still this issue

@Alkarex Alkarex modified the milestones: 1.26.0, 1.27.0 Feb 6, 2025
@Alkarex Alkarex merged commit 0217c83 into FreshRSS:edge Mar 22, 2025
1 check passed
@Alkarex
Copy link
Member

Alkarex commented Mar 22, 2025

Sorry for the delay @math-GH . Merging, but I am worried of that the buttons maybe have become a bit too small. A CSS rule such as padding: 0.3rem 0.6rem; seems closer to what we had before.

@math-GH math-GH deleted the fix/6262-scrollbar-15px-font-size branch March 24, 2025 21:01
@Alkarex Alkarex modified the milestones: 1.27.0, 1.26.2 Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI 🎨 User Interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Unwanted scrollbar on the body when setting a root font-size of 15px

4 participants