Fix XPath for HTML documents with broken root#6774
Merged
Alkarex merged 1 commit intoFreshRSS:edgefrom Sep 4, 2024
Merged
Conversation
fix FreshRSS#6773 The default `.//` prefix for the XPath does not to work for documents, which have content after the end of their main node
Member
Author
|
Example of test: <?php
$htmlString = <<<HTML
<!DOCTYPE html>
<html>
<body>
</body>
</html>
<div>div1</div>
<div>div2</div>
HTML;
$html = new DOMDocument();
$html->loadHTML($htmlString);
$xpath = new DOMXPath($html);
$divs = $xpath->query('.//div');
foreach ($divs as $div) {
echo 'Matched with .// ' . $div->nodeValue . PHP_EOL;
}
$divs = $xpath->query('//div');
foreach ($divs as $div) {
echo 'Matched with // ' . $div->nodeValue . PHP_EOL;
}Returns: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #6773
The default
.//prefix for the XPath does not work for HTML documents, which have content after the end of their main node.But
//works in both cases.