i18n improved: dotted path -> dot-notation#6317
Conversation
app/i18n/he/sub.php
Outdated
| @@ -127,12 +127,12 @@ | |||
| 'xpath' => 'XPath for:', // TODO | |||
| ), | |||
| 'json_dotpath' => array( | |||
There was a problem hiding this comment.
Should we rename the key json_dotpath too? (f.e. json_dotnotation?
There was a problem hiding this comment.
Done.
But there are much more "dotpath" attributes/variables
Frenzie
left a comment
There was a problem hiding this comment.
I'd keep them as is typical in English, meaning dot notation, not dot-notation or dotnotation.
|
@Frenzie I would agree that |
Note that the ESLint configuration for example uses dot-notation as opposed to dot_notation or dotNotation but all of those refer to "dot notation". |
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
|
I think we should update the name of the file |
could we merge this PR first and do the refactoring in another PR? It would reduce double work for the translators :) |
|
Fine by me, and better for future git blame really, though I'm not really sure what difference it'd make to the translations? |
right now they translate |
Ref. #5662
see discussion there #5662 (comment)
Changes proposed in this pull request:
dotted path->dot-notationdotted path->dot-notatedPull request checklist: