Skip to content

Remove variable default_category#5945

Merged
Alkarex merged 1 commit intoFreshRSS:edgefrom
Alkarex:fix-default_category
Dec 14, 2023
Merged

Remove variable default_category#5945
Alkarex merged 1 commit intoFreshRSS:edgefrom
Alkarex:fix-default_category

Conversation

@Alkarex
Copy link
Member

@Alkarex Alkarex commented Dec 14, 2023

Not really used, and causing bug in #5942

Fatal error: Uncaught Error: Typed property FreshRSS_View::$default_category must not be accessed before initialization in /var/www/FreshRSS/app/views/helpers/category/update.phtml:218
Stack trace:
#0 /var/www/FreshRSS/lib/Minz/View.php(93): include()
#1 /var/www/FreshRSS/lib/Minz/View.php(143): Minz_View->includeFile()
#2 /var/www/FreshRSS/app/views/category/update.phtml(9): Minz_View->renderHelper()
#3 /var/www/FreshRSS/lib/Minz/View.php(93): include('...')
#4 /var/www/FreshRSS/lib/Minz/View.php(115): Minz_View->includeFile()
#5 /var/www/FreshRSS/lib/Minz/View.php(75): Minz_View->render()
#6 /var/www/FreshRSS/lib/Minz/Dispatcher.php(59): Minz_View->build()
#7 /var/www/FreshRSS/lib/Minz/FrontController.php(61): Minz_Dispatcher->run()
#8 /var/www/FreshRSS/p/i/index.php(59): Minz_FrontController->run()
#9 {main} thrown in /var/www/FreshRSS/app/views/helpers/category/update.phtml on line 218

Not really used, and causing bug in FreshRSS#5942

```
Fatal error: Uncaught Error: Typed property FreshRSS_View::$default_category must not be accessed before initialization in /var/www/FreshRSS/app/views/helpers/category/update.phtml:218 Stack trace: #0 /var/www/FreshRSS/lib/Minz/View.php(93): include() #1 /var/www/FreshRSS/lib/Minz/View.php(143): Minz_View->includeFile() #2 /var/www/FreshRSS/app/views/category/update.phtml(9): Minz_View->renderHelper() #3 /var/www/FreshRSS/lib/Minz/View.php(93): include('...') #4 /var/www/FreshRSS/lib/Minz/View.php(115): Minz_View->includeFile() #5 /var/www/FreshRSS/lib/Minz/View.php(75): Minz_View->render() #6 /var/www/FreshRSS/lib/Minz/Dispatcher.php(59): Minz_View->build() #7 /var/www/FreshRSS/lib/Minz/FrontController.php(61): Minz_Dispatcher->run() #8 /var/www/FreshRSS/p/i/index.php(59): Minz_FrontController->run() #9 {main} thrown in /var/www/FreshRSS/app/views/helpers/category/update.phtml on line 218
```
@Alkarex Alkarex added this to the 1.23.0 milestone Dec 14, 2023
@Alkarex Alkarex merged commit a3ed826 into FreshRSS:edge Dec 14, 2023
@Alkarex Alkarex deleted the fix-default_category branch December 14, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant