Skip to content

Complete PHPStan Level 6#5305

Merged
Alkarex merged 13 commits intoFreshRSS:edgefrom
Alkarex:phpstan6-done
Apr 17, 2023
Merged

Complete PHPStan Level 6#5305
Alkarex merged 13 commits intoFreshRSS:edgefrom
Alkarex:phpstan6-done

Conversation

@Alkarex
Copy link
Member

@Alkarex Alkarex commented Apr 15, 2023

Fix #4112
And initiate PHPStan Level 7

Fix FreshRSS#4112
And initiate PHPStan Level 7
@Alkarex Alkarex added the System care Everything related to system care label Apr 15, 2023
@Alkarex Alkarex added this to the 1.22.0 milestone Apr 15, 2023
@Alkarex
Copy link
Member Author

Alkarex commented Apr 15, 2023

  • We still lack the ./tests/ folder though, if you could be interested @ColonelMoutarde

FreshRSS/phpstan.neon

Lines 17 to 18 in efcc8f3

# TODO: include tests
- tests/*

Edit: Done!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To replace unused class removed in #5251

@Alkarex Alkarex merged commit f3760f1 into FreshRSS:edge Apr 17, 2023
@Alkarex Alkarex deleted the phpstan6-done branch April 17, 2023 06:30
@math-GH
Copy link
Contributor

math-GH commented Apr 17, 2023

Awesome final run. Great work!

// HTML-encoding/escaping of the relevant fields (all except 'content')
foreach (['author', 'categories', 'guid', 'link', 'thumbnail', 'timestamp', 'title'] as $key) {
if (!empty($item[$key])) {
if (!empty($item[$key]) && is_string($item[$key])) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression #7325

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #7345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

System care Everything related to system care

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHPStan level 6

3 participants