Skip to content

Use Composer#4319

Closed
yguedidi wants to merge 3 commits intoFreshRSS:edgefrom
yguedidi:use_composer
Closed

Use Composer#4319
yguedidi wants to merge 3 commits intoFreshRSS:edgefrom
yguedidi:use_composer

Conversation

@yguedidi
Copy link

Changes proposed in this pull request:

  • use Composer for autoloading
  • move PHPMailer as a Composer dependency
  • maybe more?

How to test the feature manually:

  1. just play with the app

Pull request checklist:

  • clear commit messages
  • code manually tested
  • documentation updated

@Alkarex
Copy link
Member

Alkarex commented Apr 18, 2022

Thanks for the draft (not working though). Closing for now as responded on #4317 (reply in thread) but might become handy in the future

@Alkarex Alkarex closed this Apr 18, 2022
@yguedidi yguedidi deleted the use_composer branch April 18, 2022 16:25
@yguedidi
Copy link
Author

no problem @Alkarex ! I was prepared that it may certainly end up being closed :)

not working though

what was the issue?

@Alkarex
Copy link
Member

Alkarex commented Apr 18, 2022

what was the issue?

From memory of quick test: the code stopped at an unmet dependency (FreshRSS_Context). But from the diff, several other things would likely fail, such as some of the removed require/include (e.g. require_once(LIB_PATH . '/favicons.php');), and our Docker builds.

@yguedidi
Copy link
Author

@Alkarex really weird! on my local I managed to make it work perfectly!
have you run composer install? have you rebuild the Docker container after?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants