Skip to content

two new hooks#3342

Merged
Alkarex merged 4 commits intoFreshRSS:masterfrom
cn-tools:master
Jan 7, 2021
Merged

two new hooks#3342
Alkarex merged 4 commits intoFreshRSS:masterfrom
cn-tools:master

Conversation

@cn-tools
Copy link
Contributor

@cn-tools cn-tools commented Jan 7, 2021

For my new extension Copy2Clipboard i need 2 new hooks.

Changes proposed in this pull request:

  • Add hook to add some navigation options: Now the developers of extensions have the chance to add additional navigation points. In my case, i add an COPY button.
  • Add hook to add some jsonVars: In my case i need some translated texts in the javascript section. With this hook i can add this texts into the jsonVar script-tag and in my javascript code i can use this text with context.extensions.copy2clipboard.msg_good_more.

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated - EN only!

Additional information can be found in the documentation.

I develop a new extension and i need 2 new hooks for it
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

@aledeg
Copy link
Member

aledeg commented Jan 7, 2021

@cn-tools LGTM but could you explain the use-cases a bit more? I am not sure I understand the idea behind that.
Anyway, thank you for contributing!

@cn-tools
Copy link
Contributor Author

cn-tools commented Jan 7, 2021

@Frenzie thx ... typo changed
@aledeg thx ... i added more infos in the top

@aledeg
Copy link
Member

aledeg commented Jan 7, 2021

Nice!
Could you share your extension to check how you are using those new hooks?

@cn-tools
Copy link
Contributor Author

cn-tools commented Jan 7, 2021

@aledeg a link to my extension(s) is in the top available

a PR into freshrss-extensions repo with infos about it will come if this PR is merged 😁

@Alkarex Alkarex added this to the 1.18.0 milestone Jan 7, 2021
@Alkarex Alkarex merged commit ef45899 into FreshRSS:master Jan 7, 2021
</a>
</div>

<div class="stick" id="nav_menu_hooks">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, I did not notice at first, but this made a layout change:

Before:

image

After:

image

Could you please try to fix @cn-tools ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups ... please have a look at #3362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants