lib_phpQuery support PHP 8#3186
lib_phpQuery support PHP 8#3186Alkarex merged 7 commits intoFreshRSS:masterfrom prashanttholia:support-php-8
Conversation
Replaced create_function calls with anonymous functions in lib/lib_phpQuery.php Ref Issue: #3082
|
Thanks @prashanttholia , that looks good. I will have a look shortly. |
|
Hi @Alkarex, I had tested separately only the update I made in CallbackBody class, but did not test the other updates. I'll test them too and post about it here. |
Fix: Fatal error: Array and string offset access syntax with curly braces is no longer supported in /FreshRSS/lib/lib_phpQuery.php on line 2174, etc.
|
Let's continue testing in the main branch. |
|
@Alkarex, I have been working on points to integrate PHP 8 changes. I understand that I have not been as prompt, but I would request you to allow me to do it. I request you to let me know whether shall I continue to use this PR to commit my updates? |
|
@prashanttholia You are very welcome. Please open a new PR. It was fine with that PR focussing on a single library |
|
@Alkarex, okay, thanks a lot. One more point I wanted to mention was that I had tested the changes made in the library. The changes were made at 3 places in the file -
I wanted to mention few points about these. Thanks. |
|
Thanks for the detailed explanation @prashanttholia , and that looks sufficient for now 👍 |
|
Okay, thanks. |
Project updates to support PHP 8.
Closes #3082
Changes proposed in this pull request:
How to test the feature manually:
Pull request checklist: