Skip to content

Feature/upgrade extension system#3053

Draft
aledeg wants to merge 4 commits intoFreshRSS:edgefrom
aledeg:feature/upgrade-extension-system
Draft

Feature/upgrade extension system#3053
aledeg wants to merge 4 commits intoFreshRSS:edgefrom
aledeg:feature/upgrade-extension-system

Conversation

@aledeg
Copy link
Member

@aledeg aledeg commented Jun 12, 2020

Closes #2900

Changes proposed in this pull request:

  • Update extension from github
  • Install extension from github
  • Move extension actions in the table
  • Hide system extensions when not admin
  • Sort extension list
  • Add a status column in extension list

How to test the feature manually:

  1. install extension
  2. update extension
  3. delete extension
  4. configure extension

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

Additional information can be found in the documentation.

@aledeg
Copy link
Member Author

aledeg commented Jun 12, 2020

The install and update parts are missing for now. I need some guidance/idea on how to proceed. I am not sure what is the best way to handle that considering our code base.

@Alkarex Alkarex added this to the 1.17.0 milestone Jun 12, 2020
@aledeg aledeg force-pushed the feature/upgrade-extension-system branch from 2d4048a to 758036d Compare June 14, 2020 05:40
@Alkarex
Copy link
Member

Alkarex commented Jun 14, 2020

That is a nice feature @aledeg 👍

Here is a bit of preliminary brainstorming:

  • Consider where to automatically install those extensions:
    • We have ./extensions/ but only ./data/ is supposed to be writeable by the Web server (in installations, which do not perform Web-based updates).
    • Should we allow non-admin users to install their extensions in a user-specific extensions directory? Like ./data/users/alice/extensions/
    • Should we move ./extensions/ to ./data/extensions/ and allow only admins to install extensions there? Alternatively, update our guides and distributions to ask ./extensions/ to be writeable, but I am not so found of it.
  • (Not necessarily for this PR): Reconsider where extensions are supposed to save their data
    • Check e.g. the existing ./data/extensions-data/
    • Different for global or user extensions?
  • How to download the extensions:

@aledeg
Copy link
Member Author

aledeg commented Jun 14, 2020

Thank you for your insight. I'll look into that later!

@SuperSandro2000
Copy link
Contributor

Should we allow non-admin users to install their extensions in a user-specific extensions directory? Like ./data/users/alice/extensions/

This sounds like a security nightmare and extensions might require extra php modules. Enable on per user basis sounds fine but this not.

@Alkarex
Copy link
Member

Alkarex commented Jun 14, 2020

@SuperSandro2000 You are right, until we have better permissions, that is premature

@aledeg aledeg force-pushed the feature/upgrade-extension-system branch 3 times, most recently from 611c6cc to 9193ab4 Compare June 15, 2020 06:24
@aledeg aledeg force-pushed the feature/upgrade-extension-system branch from 9193ab4 to 2974aea Compare June 26, 2020 15:56
@aledeg aledeg force-pushed the feature/upgrade-extension-system branch from 2974aea to 06a34a6 Compare July 15, 2020 19:35
@Alkarex Alkarex modified the milestones: 1.17.0, 1.18.0 Sep 2, 2020
@Alkarex Alkarex modified the milestones: 1.18.0, 1.19.0 Jan 3, 2021
Base automatically changed from master to edge March 14, 2021 18:46
@Alkarex Alkarex modified the milestones: 1.19.0, 1.20.0 Oct 29, 2021
@math-GH math-GH removed this from the 1.20.0 milestone Feb 6, 2022
@math-GH math-GH added the BLOCKED ❌ merge conflict or failing tests that block the PR label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLOCKED ❌ merge conflict or failing tests that block the PR Extension 🔌 help wanted UI 🎨 User Interfaces Update action 💾 Work in progress 🚧 Wait before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button install extensions

4 participants