Update ReadingTime extension (remove Jquery)#50
Merged
Frenzie merged 5 commits intoFreshRSS:masterfrom May 28, 2019
lapineige:master
Merged
Update ReadingTime extension (remove Jquery)#50Frenzie merged 5 commits intoFreshRSS:masterfrom lapineige:master
Frenzie merged 5 commits intoFreshRSS:masterfrom
lapineige:master
Conversation
Frenzie
reviewed
May 28, 2019
| //console.log('Reading time: ', reading_time.read_time) | ||
| return reading_time.read_time; | ||
| }, | ||
| flux: null, |
Member
There was a problem hiding this comment.
Is the change in indentation on purpose?
| if (document.body.clientWidth <= 840) { // in mobile mode, the feed name is not visible (there is only the favicon) | ||
| // add the reading time right before article's title | ||
| // in that case, [Time] - [Title] format is used instead of a "|" (as it looks better and doesn't take much more space) | ||
| if ( $("#" + reading_time.flux.id + " ul.horizontal-list li.item.title a")[0].textContent.substring(0,(reading_time.reading_time + 'm - ').length) != reading_time.reading_time + 'm - ' ) { |
Contributor
Author
There was a problem hiding this comment.
Oh, thanks, I did not notice this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix FreshRSS/FreshRSS#1260 (comment)