Merged
Conversation
Inverle
reviewed
Nov 23, 2025
| declare(strict_types=1); | ||
|
|
||
| class FreshExtension_auth_Controller extends FreshRSS_auth_Controller { | ||
| class FreshExtension_authCaptcha_Controller extends FreshRSS_auth_Controller { |
Member
There was a problem hiding this comment.
Both the filename change and class name change make this extension no longer work properly (since this is now a new controller, instead of overriding auth).
This requires a further look for a working solution.
Member
Author
There was a problem hiding this comment.
Right. I am afraid the approach of overriding classes like that only works with one extension at a time
Member
There was a problem hiding this comment.
So hooks would be needed in 2 places then, after all.
Or maybe it's possible to add support for overriding an action with multiple extensions at once into Minz.
Inverle
approved these changes
Nov 23, 2025
Member
Author
|
Help welcome to rethink the approach, preferably with extension hooks, or with a reworked overriding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#364 (comment)
Testing needed