Update PKCS #11 in LTS development branch #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhui-zheng
approved these changes
Jun 18, 2020
Contributor
yuhui-zheng
left a comment
There was a problem hiding this comment.
Glanced over, and approving with the understanding that this is to sync between copies.
| } else { | ||
| xResult = CKR_OBJECT_HANDLE_INVALID; | ||
| } | ||
| case ( CKA_CLASS ): |
Contributor
There was a problem hiding this comment.
Minor, and fyi... People typically add comments like "fall through intentionally" on empty cases.
Contributor
Author
There was a problem hiding this comment.
I ended up removing this change, I think the release branch was cut before I reverted it. I was being clever to reduce the GNU Complexity, but MISRA did not agree with this change, even with the fall through comments. :(
| xResult = CKR_ARGUMENTS_BAD; | ||
| } | ||
|
|
||
| if (xResult == CKR_OK) { | ||
| if (NULL == pxSlotList) { | ||
| if( xResult == CKR_OK ) |
Contributor
There was a problem hiding this comment.
Minor and fyi... I would stick to one style, either var==condition or condition==var. Some prefer later, since that's safer even == is mistakenly changed to single =.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update PKCS #11 in LTS development branch
Description
This PR syncs the LTS branch with release-candidate branch on AFR
Test Steps
Run PKCS #11 demo locally
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.