Added fallback for hovering lookup on Linux systems#133
Merged
1over137 merged 6 commits intoFreeLanguageTools:masterfrom Jan 28, 2024
Merged
Added fallback for hovering lookup on Linux systems#1331over137 merged 6 commits intoFreeLanguageTools:masterfrom
1over137 merged 6 commits intoFreeLanguageTools:masterfrom
Conversation
This reverts commit baa7410.
Contributor
|
Cool, but don't check for Linux, rather check for wayland directly, like this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per requested, I added the fallback for hovering lookup with the shift key. So it should now work on Linux, though the window must be focused. However, I think that it would be more useful if we let the user decide whether they want the fallback or not, but I didn't add that feature so we can discuss it and see what works best for you. The pynput documentation states that if the script is running under X, it should work regardless of the sudo privileges. This way, if someone it's still using X, they might benefit from using the hovering lookup feature even when the window is unfocused.