(I don't have any experience with this codebase so maybe these are not bugs.)
|
} if (unit.isAtLocation(destination)) { |
The formatting is strange, the if-statement start on same line as a closing brace, is an else missing before the if? If no else is missing then the if-statement should probably moved to a line of its own.
|
if (expert != null |
|
&& u.getUnitChange(UnitChangeType.EXPERIENCE, expert) != null) { |
|
score += 10000; |
|
} else if (expert != null |
|
&& u.getUnitChange(UnitChangeType.EXPERIENCE, expert) != null) { |
|
score -= 10000; |
|
} |
The two if-statements have the same condition.
|
/ ((tcb.getBottomRightDirtyTile().getX()-tcb.getTopLeftDirtyTile().getX()) * (tcb.getBottomRightDirtyTile().getY()-tcb.getBottomRightDirtyTile().getY())); |
Identical expressions (tcb.getBottomRightDirtyTile().getY()) on both sides of subtraction operator.
(I don't have any experience with this codebase so maybe these are not bugs.)
freecol/src/net/sf/freecol/client/control/InGameController.java
Line 975 in ef483bd
The formatting is strange, the if-statement start on same line as a closing brace, is an
elsemissing before theif? If noelseis missing then the if-statement should probably moved to a line of its own.freecol/src/net/sf/freecol/server/ai/ColonyPlan.java
Lines 1054 to 1060 in ef483bd
The two if-statements have the same condition.
freecol/src/net/sf/freecol/client/gui/mapviewer/MapViewer.java
Line 496 in ef483bd
Identical expressions (
tcb.getBottomRightDirtyTile().getY()) on both sides of subtraction operator.