Skip to content

Conversation

@cfs6t08p
Copy link

The current BLE implementation has a few issues;

  1. It tries to connect to every single BLE device nearby just to check if it's a Launch
  2. It will try (and fail) to connect to the same device multiple times, each time the device sends an advertisement
  3. To make issue 2 worse, there's an unnecessary 1 second delay when trying to connect to a Launch
  4. It is too eager to re-start discovery, this process will likely go on forever even if a successful connection is made

With these changes it should

  • Connect instantly (BLE stack won't be overloaded trying to connect to everything & 1 second delay removed)
  • Not cause issues with BLE devices you didn't want your PC to connect to
  • Reliably stop the discovery process once a device has been found

@FredTungsten FredTungsten merged commit ece1da7 into FredTungsten:master Sep 18, 2022
@FredTungsten
Copy link
Owner

Thanks 👍

@televore
Copy link

televore commented Aug 15, 2024

Well, how do I connect to the launch now that the option is not available anymore in the list of devices in the device menu ?? I'm trying to find the previous version without success...
EDIT: I found the previous version and reverted, until you explain how it works now with the launch device...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants