Experimental Volume Ramping feature for FunStimAudioDevice #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (causing no estim output)
effects" that have become popular with handy users recently, which fire many super short actions that result in durations below the audio buffer runtime. 10% deviation between actions should still be safe to not unexpectedly shock anybody.
allows a gradual ramping up of the intensity of the FunStim device output over the duration of a video. A setting of 0% implies to ramp up. A setting of 100% implies a ramp up from zero intensity to full intensity over the duration of the video. This is my first try to add a major feature, and it might be incomplete or not the correct way to implement. Definitely needs testing! Comments Welcome.
Owner
|
Thanks for contributing 👍 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there :)
This is my first attempt at adding a feature to ScriptPlayer.
This commit adds an experimental feature that allows a gradual ramping up of the intensity of the FunStim device output over the duration of a video. It adds a new setting in the funscript converter settings dialog, and a few changes throughout the entire event chain making it possible to pass through the total duration of the currently playing file.
I have literally no idea if that's the best way to implement this feature - I tried to go with the existing design and be as minimally invasive as I can. But I'm almost certain I've forgotten some edge cases, and this definitely needs some oversight and testing :)