Small bugfix and one suggestion #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (causing no estim output)
effects" that have become popular with handy users recently, which fire many super short actions that result in durations below the audio buffer runtime. 10% deviation between actions should still be safe to not unexpectedly shock anybody.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This pull request has two small changes to the FunStimSampleProvider. The first change fixes a division by zero that occurs when you set the fade time to 0ms.
The second change is a suggestion, which makes the skip protection a little bit more tolerant to "vibration patterns" that are becoming somewhat popular in the handy community recently, which use very short-spaced commands that result in actions that never quite reach their target value because the read function can't react faster to actions than the runtime of one audio buffer.