fix: Correct client/device mismatching #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I took a few attampts at this, but eventually worked out that connects were blotting eachother and not resetiing the device list, so the devices were referring to the wrong clients. This resolved the FredTungsten#168 like crashes I could reproduce. I also abstracted out the error recording, since there a lot of places that exceptions could be thrown and should just be handled by logging. The disconnect system also got tweaked, so that all disconnects are handled in the same way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a few attampts at this, but eventually worked out that
connects were blotting eachother and not resetiing the device
list, so the devices were referring to the wrong clients.
This resolved the #168 like crashes I could reproduce.
I also abstracted out the error recording, since there a lot of
places that exceptions could be thrown and should just be
handled by logging.
The disconnect system also got tweaked, so that all
disconnects are handled in the same way.