NCP-3701 - CircleCI node upgrade to v22 by AlbertPangilinan · Pull Request #7 · Foxquilt/foxden-node-saml

AlbertPangilinan · 2025-09-17T15:20:04Z

Jira Link

Jira ticket is here

Synopsis

Rebased forked repo to latest node-saml version
Upgraded CircleCI node version to 22

Bumps [xml-encryption](https://github.com/auth0/node-xml-encryption) from 3.0.1 to 3.0.2. - [Release notes](https://github.com/auth0/node-xml-encryption/releases) - [Commits](https://github.com/auth0/node-xml-encryption/commits) --- updated-dependencies: - dependency-name: xml-encryption dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [xml2js](https://github.com/Leonidas-from-XIV/node-xml2js) from 0.4.23 to 0.5.0. - [Release notes](https://github.com/Leonidas-from-XIV/node-xml2js/releases) - [Commits](https://github.com/Leonidas-from-XIV/node-xml2js/commits/0.5.0) --- updated-dependencies: - dependency-name: xml2js dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Chris Barth <chrisjbarth@hotmail.com>

Bumps [vm2](https://github.com/patriksimek/vm2) from 3.9.16 to 3.9.19. - [Release notes](https://github.com/patriksimek/vm2/releases) - [Changelog](https://github.com/patriksimek/vm2/blob/master/CHANGELOG.md) - [Commits](patriksimek/vm2@3.9.16...3.9.19) --- updated-dependencies: - dependency-name: vm2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v2.2.1...v2.2.3) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [prettier](https://github.com/prettier/prettier) from 2.8.7 to 2.8.8. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.8.7...2.8.8) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.58.0 to 5.59.8. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.59.8/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.1 to 3.1.4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3.1.1...v3.1.4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [concurrently](https://github.com/open-cli-tools/concurrently) from 7.6.0 to 8.2.0. - [Release notes](https://github.com/open-cli-tools/concurrently/releases) - [Commits](open-cli-tools/concurrently@v7.6.0...v8.2.0) --- updated-dependencies: - dependency-name: concurrently dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.59.9 to 5.60.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.60.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.8.4 to 5.1.6. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Allow 5.x series for TypeScript --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ed" (node-saml#397)

sharonsitu · 2025-09-22T19:42:22Z

.vscode/settings.json

@@ -0,0 +1,31 @@
+{


looks like not relative change?

sharonsitu · 2025-09-22T19:46:00Z

package.json

  },
  "engines": {
-    "node": ">= 14"
+    "node": ">= 18"


maybe >= 22?

sharonsitu · 2025-09-22T19:51:05Z

just found that this repo has both package-lock and yarn.lock

sharonsitu · 2025-09-22T20:29:27Z

Looks like there are few types either renamed or removed, just make sure those will not affect the downstream... others look good.

AlbertPangilinan force-pushed the NCP-3701-circleci-node-22 branch from 5c17495 to 0ae0106 Compare September 22, 2025 15:14

dependabot bot and others added 29 commits September 22, 2025 11:27

Release 4.0.4

0bf7a15

Update minor dependencies (node-saml#269)

b0d8b24

Improve audience mismatch error message (node-saml#257)

e69040f

feat: add public getAuthorizeMessage method (node-saml#235)

ffbf205

Acknowledge that XML can be parsed to any (node-saml#271)

afda73c

feat: support additionalParams on HTTP-POST binding (node-saml#263)

cf999ab

Make callbackUrl manditory (node-saml#214)

41aa04d

Add public key support (node-saml#225)

1644f24

Co-authored-by: Chris Barth <chrisjbarth@hotmail.com>

Remove types specific to Passport (node-saml#226)

b07dd1b

Export types required for SamlOptions (node-saml#224)

6a5e6ba

Update minor dependencies (node-saml#283)

a308921

Roll-up changelog entries for beta releases (node-saml#282)

811e139

Fix spelling and normalize naming (node-saml#278)

5661fa8

Remove express dependency (node-saml#284)

5c2768c

Prefer Chai expect to Node assert (node-saml#286)

0a0306c

Add test coverage (node-saml#287)

04e92de

Separate linting out from testing (node-saml#288)

1b41473

Remove dependency on Passport types (node-saml#296)

8f6e564

Add tests for XML parsing with comments (node-saml#285)

c914de9

ahacker1-securesaml and others added 14 commits September 22, 2025 11:32

Use new .signedReferences interace in xml-crypto to "see what is sign…

42c2bef

…ed" (node-saml#397)

Update sponsors: Stytch (node-saml#395)

b5d013e

Release 5.1.0

0650558

Update to support Node strip-only TypeScript support (node-saml#407)

62715ba

Security: remove debug dependency (node-saml#406)

c75d320

ARCH-32 node_saml changes

de71d25

ARCH-32_fixed test

41307d9

ARCH-32 updated the review comments

83c578d

ARCH-32 package.json changes

59ee1ec

ARCH-32 updated package json

1dfc779

ARCH-32 access to public

6c37532

upgraded circleci node version to 22

a7da48e

updated yarn.lock

8540574

removed package-lock.json

0343da5

AlbertPangilinan force-pushed the NCP-3701-circleci-node-22 branch from 16dcd98 to 0343da5 Compare September 22, 2025 15:41

AlbertPangilinan added 5 commits September 22, 2025 11:42

reset config.yml except for node version

26444d2

reset workflow.yml

c1ab2a4

added 22.x to node-version matrix

28bac76

fixed package-lock.json

d46c61b

fixed package-lock.json and yarn.lock

260620b

sharonsitu reviewed Sep 22, 2025

View reviewed changes

.vscode/settings.json

@@ -0,0 +1,31 @@

{

Copy link

sharonsitu Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like not relative change?

Eric-G-Ji reacted with thumbs up emoji

sharonsitu reviewed Sep 22, 2025

View reviewed changes

package.json Outdated

},

"engines": {

"node": ">= 14"

"node": ">= 18"

Copy link

sharonsitu Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe >= 22?

Eric-G-Ji reacted with thumbs up emoji

Eric-G-Ji approved these changes Sep 22, 2025

View reviewed changes

sharonsitu closed this Sep 22, 2025

sharonsitu reopened this Sep 22, 2025

sharonsitu approved these changes Sep 22, 2025

View reviewed changes

fixed node version number in package.json

4f80578

AlbertPangilinan merged commit 84b41f5 into master Sep 23, 2025
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NCP-3701 - CircleCI node upgrade to v22#7

NCP-3701 - CircleCI node upgrade to v22#7
AlbertPangilinan merged 89 commits intomasterfrom
NCP-3701-circleci-node-22

AlbertPangilinan commented Sep 17, 2025 •

edited

Loading

Uh oh!

sharonsitu Sep 22, 2025

Uh oh!

sharonsitu Sep 22, 2025

Uh oh!

sharonsitu commented Sep 22, 2025

Uh oh!

sharonsitu commented Sep 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

AlbertPangilinan commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jira Link

Synopsis

Uh oh!

sharonsitu Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sharonsitu Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

sharonsitu commented Sep 22, 2025

Uh oh!

sharonsitu commented Sep 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

AlbertPangilinan commented Sep 17, 2025 •

edited

Loading