Merged
Conversation
Use async unsubscribe with a bounded timeout to prevent hanging
Uses fire and forget unsubscribe to prevent potential hanging issues. Adds unique topic names to Redis tests to prevent interference between tests.
Adds try-catch blocks when unsubscribing from Redis topics to prevent potential unhandled exceptions from causing issues, particularly in test environments where flaky behavior might occur. Logs any exceptions encountered during the unsubscribe process for better debugging.
Comment on lines
+785
to
+788
| catch (Exception ex) | ||
| { | ||
| _logger.LogError(ex, "Error unsubscribing from topic {Topic}: {Message}", GetTopicName(), ex.Message); | ||
| } |
Member
Author
|
@copilot Please run tests multiple times and find the root cause of why there are test failures. The tests always pass locally but fail on the ci so there it's resource bound. |
|
@niemyjski I've opened a new pull request, #130, to work on those changes. Once the pull request is ready, I'll request review from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.