[Breaking] CacheClient ensure consistent return values for expires in.#128
Merged
[Breaking] CacheClient ensure consistent return values for expires in.#128
Conversation
niemyjski
commented
Jan 1, 2026
| @@ -1,13 +1,10 @@ | |||
| if math.modf(@value) == 0 then | |||
| local integral, fractional = math.modf(@value) | |||
| if fractional == 0 then | |||
Member
Author
There was a problem hiding this comment.
we don't call this unless an expires is passed in, otherwise we just call StringIncrementAsync. Thus we could simplify
There was a problem hiding this comment.
Copilot reviewed 16 out of 16 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… strings preserves decimal precision for doubles
…e()) which fails on macOS when the hostname has a .local suffix The issue was that the original script used [System.Net.Dns]::GetHostAddresses([System.Net.Dns]::GetHostName()) which fails on macOS when the hostname has a .local suffix (like Blake-Work-MBP.local). This is because .local domains use mDNS (multicast DNS/Bonjour) rather than regular DNS, and the .NET DNS resolver doesn't handle mDNS. The fix uses [System.Net.NetworkInformation.NetworkInterface]::GetAllNetworkInterfaces() which: Is a standard .NET API that works on Windows, macOS, and Linux Directly queries network interfaces instead of relying on DNS resolution Doesn't require try-catch since it's querying local system state Filters for active, non-loopback interfaces with valid IPv4 addresses (excluding link-local 169.254.* addresses)
…tHostName()) which fails on macOS when the hostname has a .local suffix" This reverts commit 7355c10.
This reverts commit 36c26aa.
Comment on lines
+788
to
+791
| catch (Exception ex) | ||
| { | ||
| _logger.LogError(ex, "Error unsubscribing from topic {Topic}: {Message}", GetTopicName(), ex.Message); | ||
| } |
16c0d5b to
64a5092
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to:
FoundatioFx/Foundatio@6263889
FoundatioFx/Foundatio#432