This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Use filepath package throughout for Windows support#34
Merged
FooSoft merged 1 commit intoFooSoft:masterfrom Dec 14, 2021
Merged
Use filepath package throughout for Windows support#34FooSoft merged 1 commit intoFooSoft:masterfrom
FooSoft merged 1 commit intoFooSoft:masterfrom
Conversation
Contributor
Author
|
Please note that this PR contains all of my recent fixes. However, after moving some functions around I couldn't really make this one work on its own, so please have a look at my other PRs first and see if they can be merged. If those would be completed then I can rebase this PRs branch to be clean, at which point the history is straightforward again. This is the main reason why I marked this as a "Draft PR". |
Owner
|
The other PRs look fine and have been merged! |
The "path" package supports only forward slashes in paths, like those found in *nix operating systems or URLs. Meanwhile Windows with its CP/M and QDOS ancestry requires drive letters and backslashes, and thus the "filepath" package needs to be used.
e376da9 to
edb42a0
Compare
Contributor
Author
|
@FooSoft Thank you. I've rebased my changes so that this PR looks cleaner. |
Owner
|
Yep, this looks good -- thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "path" package supports only forward slashes in paths, like those found in *nix operating systems or URLs.
Meanwhile Windows with its CP/M and QDOS ancestry requires drive letters and backslashes, and thus the "filepath" package needs to be used. This packages handles all the gnarly edge cases on different platforms and will make sure that all paths are properly normalized.
I've been able to use homemaker on Windows without this fix, but the experience has been bad.