This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Don't create a blank template when parsing templates#22
Merged
FooSoft merged 1 commit intoFooSoft:masterfrom Sep 5, 2017
Merged
Don't create a blank template when parsing templates#22FooSoft merged 1 commit intoFooSoft:masterfrom
FooSoft merged 1 commit intoFooSoft:masterfrom
Conversation
This created a template with two entries within it; using template.Execute would execute an empty template when you attempted to use templates within a sub-directory
Owner
|
Looks good, thank you for the contribution. |
|
I'm actually running into this with the latest release tarballs as well. Any chance those could be updated so I can pull them into my repo? Thanks for your project, btw. It fits my use-case perfectly. :) |
Owner
|
@aphistic binaries updated! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran across a bug where using a template in a subdirectory would fail because it was reading an empty template. Here's the task I was using:
Using template.New() created a new, empty-content template with the name "git/user.inc.tmpl".
Afterwards, using .ParseFiles() creates another template with the name "user.inc.tmpl" with my template.
Finally, when .Execute is called, it picked the first, empty template "git/user.inc.tmpl".
This works fine when you don't place templates in subdirectories, as the name you generate matches the name .ParseFiles() does (and therefore gets clobbered with real content).
Using template.ParseTemplate() directly makes the first (and default) template for .Execute the file the user provides.