Add updateStyle method to TextInputConnectionDecorator#2917
Add updateStyle method to TextInputConnectionDecorator#2917Renzo-Olivares wants to merge 5 commits into
updateStyle method to TextInputConnectionDecorator#2917Conversation
|
@Renzo-Olivares looks like you've got multiple test failures in this PR. At first glance, they look to be related to the API you're updating. |
|
@matthew-carroll It looks like it might be because the |
|
@Renzo-Olivares for this PR at this stage, if you need other packages in the mono-repo to use your super_editor changes, then you should change the pubspec for each of those packages by adding a dependency override that points to the local version of |
|
@matthew-carroll I updated the dependencies to use the local copy of |
|
@Renzo-Olivares that's a good question. Let me think about it. We might just merge as-is and deal with it later. We'll see. I plan to get this PR merged in the next day or two. |
|
@Renzo-Olivares I deleted those pckages. I'm going to attempt to pull down your branch and rebase it. We'll see how it goes. |
|
@Renzo-Olivares gonna close this PR in favor of the copy I put up with adjustments for the removal of those 2 packages: #2950 |
In flutter/flutter#180436 a breaking change was introduced to pass additional styling information to the web engine in order to fix flutter/flutter#161592. Historically the framework passes this information using
TextInputConnection.setStyle(......), however after the breaking change the framework introducedTextInputConnection.updateStyle(TextInputStyle style)and deprecated the old method in an effort to minimize future breaking changes when passing additional style parameters to the engine.This change fixes the breakage by adding an implementation for the new method added
TextInputConnection.updateStyle.A full migration to
updateStylein addition to providing the additional styling information to the web engine will still be needed if experiencing flutter/flutter#161592.