[BUGFIX] Handle possible DBALException#2153
Merged
Merged
Conversation
We can ignore a missing database connection at this point. We cant do anything about a missing database connection. This Scenario is possible during first install.
Member
|
The exception appears to have a different class name on the version of Doctrine that's used by TYPO3v12. We'll need to handle the newer exception type, and if it isn't backwards compatible, handle both types and add the resulting warnings to the phpstan baseline. |
added 2 commits
March 30, 2024 10:59
since the generic is deprecated
Author
|
Thanks for looking into it! The exception class was deprecated and then renamed in the newest doctrine version. I've updated the catch case to a more specific class that exists in both the older and new versions of Doctrine. |
NamelessCoder
approved these changes
Apr 2, 2024
Member
|
Thanks for the update and the patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can ignore a missing database connection at this point. We cant do anything about a missing database connection. This Scenario is possible during first install.
In a Scenario, where flux is installed before first install, this happens:
SpooledConfigurationApplicatorthen in itsprocessDatacalls$this->spoolQueuedContentTypeRegistrationsin Line 71.$this->contentTypeBuilder->registerContentTypein Line 181 requires a Database Connection for registering the content types.Tested in Typo3 11.5.36 with flux 10.0.9