Thanks Pedro! @tsingakbar If you have some time, could you pls. run fluidsynth.exe -Q and let us know if the reported WASAPI device names still look correct? For convenience, you may use the fluidsynth-x64 prebuilt binaries: https://dev.azure.com/tommbrt/tommbrt/_build/results?buildId=10122&view=artifacts&pathAsName=false&type=publishedArtifacts

CC @nanitaro , please test as well

CC @nanitaro , please test as well

I ran fluidsynth.exe -Q on a test version.
Japanese information was output without problems as in 2.3.5 (official release version).
All variants (x64,mingw-x64,x86) have been checked.
I will upload the output log just to be sure.
fluidsynth.txt

With these changes, the users may enjoy utf8 output and input when using cmd.exe (or other shells) in Windows. The input is relevant for Fluidsynth's own shell. And this would be enough for libfluidsynth.dll clients, like Qsynth.

But there is still a loose thread: the CLI program's command line arguments are only processed/converted into utf8 for file names, but not other arguments. For instance, this would not work:

C:> fluidsynth.exe -o audio.wasapi.device=GroßeStraßenlautsprecher

Sorry for the late response, busy schedule.

It looks good to me now, thanks! If you want and have some time feel free to also UTF8 convert the commandline args.

@nanitaro Would you mind running fluidsynth.exe -Q again with these binaries? @tsingakbar CC
https://dev.azure.com/tommbrt/tommbrt/_build/results?buildId=10135&view=artifacts&pathAsName=false&type=publishedArtifacts

If everything goes well, I would apply the commits onto the release/2.3 and then merge it back to master. But probably not before next weekend, though.

@derselbst
I ran the new test binary.
I think there is no problem about outputting Japanese information.
fluidsynth_05112024.txt

Compared to the previous binary, the output result of the default device in shared and exclusive mode seems to have changed.
This time the result seems to be more accurate.

For your information, the performance and settings of the sound devices in the test environment are as follows
Default device = SPDIF interface (FX-AUDIO-DAC-X6)
Windows sound properties. Default format=2ch,24bit,96000Hz

After the commits on May 1st, not only WASAPI but also the other Windows drivers are now updated to use UTF8. There is no equivalent of -Q for the other drivers, but it should be possible to use the shell, starting fluidsynth.exe without the argument and...

> settings
[...]
> info midi.driver
Options: winmidi
> info midi.winmidi.device
[...]
> info audio.driver
Options: dsound, waveout, wasapi
[...]
>  info audio.dsound.device
>  info audio.waveout.device
>  info audio.wasapi.device

The output of all these commands should be encoded now in UTF8.

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud