fix: avoid race condition when opening side channel#47
Merged
Conversation
|
paodb
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation for opening and switching to a new browser window was causing intermittent test failures (flakiness).
testbench-rpc/src/main/java/com/flowingcode/vaadin/testbench/rpc/HasRpcSupport.java
Lines 276 to 278 in 1f7c5a4
The code was executing
window.open()via JavaScript and immediately attempting toswitchTo().window(). Becausewindow.open()is handled asynchronously by the browser's UI thread, the WebDriver command to switch would often reach the browser before the browser had finished registering the new window handle.Result: Selenium would throw an exception because the window name did not exist yet in the session's window list at the server side.