feat: add setScriptTimeout method#19
Merged
Merged
Conversation
paodb
approved these changes
Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new method called
setScriptTimeoutin order to simplify configuration of the timeout for asynchronous script execution in Selenium (which is used by RPC calls).Note that recent versions of Selenium no longer support negative values to disable the timeout. Therefore, I have implemented a workaround by using a large value instead. While the official Selenium documentation mentions support for values up to 2e16-1, I found that setting such a high value was not possible. As an alternative, I have chosen a value of 9e15, which still allows the script to execute for a considerable amount of time (a few millennia).