fix: support JsonObject#10
Merged
Merged
Conversation
paodb
approved these changes
Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In issue #7, I documented that "JsonObject is not supported." This limitation is as a particular case related to issues #3 and #4, which were not (fully) resolved in PR #5 and #6.
However, upon further investigation, it was found that implementing support for JsonObject is not as challenging as initially perceived. Therefore, I propose addressing this issue by adding support for JsonObject, as originally claimed in the documentation.
By incorporating this implementation, we can ensure that
JsonValueis fully supported and can handle the specific case ofJsonObject. This will provide a comprehensive solution for the related issues and improve the functionality of the project.