Skip to content

Allows AbstractStreamResource as images for Zoomist#25

Merged
javier-godoy merged 1 commit into
FlowingCode:masterfrom
seazzle:master
Apr 1, 2025
Merged

Allows AbstractStreamResource as images for Zoomist#25
javier-godoy merged 1 commit into
FlowingCode:masterfrom
seazzle:master

Conversation

@seazzle

@seazzle seazzle commented Mar 25, 2025

Copy link
Copy Markdown
Contributor

Currently Zoomist only allows String parameter for src.
When getting images via API as byte[] the Image is handled as StreamResource:

StreamResource streamResource = new StreamResource("image.png", () -> {
            byte[] imageBytes = myApi.getImage(id);
            return new ByteArrayInputStream(imageBytes);
        });

The change allows to use Zoomist also with StreamResource

@seazzle

seazzle commented Mar 25, 2025

Copy link
Copy Markdown
Contributor Author

Hi @javier-godoy @paodb :) could you take a look into my PR, and if you are fine provide a new release?

@javier-godoy javier-godoy moved this from In Progress to To Do in Flowing Code Addons Mar 31, 2025
@seazzle

seazzle commented Apr 1, 2025

Copy link
Copy Markdown
Contributor Author

Hi @javier-godoy, are there any issues with the PR or anything I can improve / help with? :)

@javier-godoy javier-godoy self-requested a review April 1, 2025 18:26
@javier-godoy

javier-godoy commented Apr 1, 2025

Copy link
Copy Markdown
Member

Hello @seazzle. I'll take a look.

@javier-godoy javier-godoy moved this from To Do to In Progress in Flowing Code Addons Apr 1, 2025
@javier-godoy javier-godoy merged commit 480d619 into FlowingCode:master Apr 1, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Pending release in Flowing Code Addons Apr 1, 2025
@paodb

paodb commented Apr 7, 2025

Copy link
Copy Markdown
Member

Released in version 1.1.0.

@paodb paodb moved this from Pending release to Done in Flowing Code Addons Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javier-godoy javier-godoy javier-godoy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Flowing Code Addons
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seazzle @javier-godoy @paodb