Skip to content

Maven central release#119

Merged
paodb merged 7 commits into
masterfrom
maven-central-release
Jun 9, 2026
Merged

Maven central release#119
paodb merged 7 commits into
masterfrom
maven-central-release

Conversation

@javier-godoy

@javier-godoy javier-godoy commented Jun 5, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated Maven release tooling to a newer release version with improved release configuration
    • Added profiles to support GPG artifact signing and Sonatype Central publishing
    • Adjusted when source artifacts are attached in the build lifecycle
    • Added project URL metadata to project configuration

@coderabbitai

coderabbitai Bot commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cad083e9-014a-4a61-8935-bf7d00db479b

📥 Commits

Reviewing files that changed from the base of the PR and between 1e7edcb and 2ff93a9.

📒 Files selected for processing (1)
  • pom.xml
🚧 Files skipped from review as they are similar to previous changes (1)
  • pom.xml

Walkthrough

POM updated: adds project URL, upgrades maven-release-plugin to 3.0.1 (bound to release profile), moves source attachment to package, and adds release and env-driven gpg profiles for Sonatype Central publishing and GPG signing.

Changes

Maven Central Publishing Setup

Layer / File(s) Summary
Project metadata and release plugin configuration
pom.xml		 Project url added. maven-release-plugin upgraded to 3.0.1 and configured with releaseProfiles = release.
Source attachment phase adjustment
pom.xml		 In directory profile, maven-source-plugin execution for attach-sources moved from verify to package.
Release and GPG signing profiles
pom.xml		 New release profile enables central-publishing-maven-plugin extension; new gpg profile activates on MAVEN_GPG_PASSPHRASE and configures maven-gpg-plugin to sign artifacts during verify.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related issues

  • FlowingCode/YearMonthCalendarAddon#120 — The issue requests including directory in releaseProfiles; this PR adds releaseProfiles = release, which is directly related to releaseProfile behavior mentioned in that issue.

Suggested reviewers

  • mlopezFC
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Maven central release' directly and concisely summarizes the main objective of the pull request, which is to prepare the project for publishing to Maven Central Repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch maven-central-release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@javier-godoy

javier-godoy commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai[bot]
coderabbitai Bot reviewed Jun 8, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pom.xml`:
- Around line 179-182: The release profile currently activates only the profile
identified by "release" via the releaseProfiles element, which omits the
"directory" profile that declares the maven-source-plugin and
maven-javadoc-plugin; update the releaseProfiles configuration (the
<releaseProfiles> value) to include both "release" and "directory" so that
running release:perform also activates the "directory" profile and produces
source and javadoc JARs required by Maven Central.
- Around line 530-556: Update the maven-gpg-plugin version in the gpg profile:
locate the <profile> with <id>gpg</id> and the plugin element for
org.apache.maven.plugins:maven-gpg-plugin (artifactId maven-gpg-plugin) and
change its <version> from 3.2.7 to 3.2.8 so the profile uses the latest plugin
release.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f545b3e1-af53-4230-860e-57bf8e5d6a2f

📥 Commits

Reviewing files that changed from the base of the PR and between a6fdbcd and 1e7edcb.

📒 Files selected for processing (1)
  • pom.xml

Comment thread pom.xml
Comment thread pom.xml
@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@javier-godoy javier-godoy marked this pull request as ready for review June 8, 2026 20:19
@javier-godoy javier-godoy requested review from paodb and scardanzan June 8, 2026 20:37
@paodb paodb merged commit 49d965b into master Jun 9, 2026
5 checks passed
@paodb paodb deleted the maven-central-release branch June 9, 2026 12:43
@github-project-automation github-project-automation Bot moved this from To Do to Pending release in Flowing Code Addons Jun 9, 2026
@paodb paodb moved this from Pending release to Done in Flowing Code Addons Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@paodb paodb paodb approved these changes

@scardanzan scardanzan Awaiting requested review from scardanzan

Assignees

No one assigned

Labels

None yet

Projects

Flowing Code Addons
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@javier-godoy @paodb